Skip to content

Fix json float/double print format (#7572) #7776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dcherednik merged 1 commit into from
Aug 14, 2024
Merged

Fix json float/double print format (#7572) #7776

dcherednik merged 1 commit into from
Aug 14, 2024

Conversation

@dcherednik
Copy link
Member

@dcherednik dcherednik commented Aug 14, 2024 •
edited
Loading

SELECT CAST("311111111113.222222223" as Double) should not loss precision

@dcherednik
Fix json float/double print format (ydb-platform#7572)
ea4b4f7 
SELECT CAST("311111111113.222222223" as Double) should not lost precision
@dcherednik dcherednik requested a review from a team as a code owner August 14, 2024 11:08
@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 11:12:27 UTC Pre-commit check for 28c748a has started.
⚪ 2024-08-14 11:15:32 UTC Build linux-x86_64-release-asan is running...
🟢 2024-08-14 11:38:47 UTC Build successful.
⚪ 2024-08-14 11:39:02 UTC Tests are running...
🔴 2024-08-14 13:33:37 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
9621 9572 0 11 26 12

🟢 2024-08-14 13:34:13 UTC ydbd size 5.5 GiB changed* by -96 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 74a9fd5 merge: 28c748a diff diff %
ydbd size 5 904 419 688 Bytes 5 904 419 592 Bytes -96 Bytes -0.000%
ydbd stripped size 1 480 270 112 Bytes 1 480 270 048 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 11:14:34 UTC Pre-commit check for 28c748a has started.
⚪ 2024-08-14 11:17:35 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-08-14 11:38:34 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Aug 14, 2024 •
edited
Loading

⚪ 2024-08-14 11:20:10 UTC Pre-commit check for 28c748a has started.
⚪ 2024-08-14 11:23:12 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-08-14 12:00:42 UTC Build successful.
⚪ 2024-08-14 12:00:57 UTC Tests are running...
🔴 2024-08-14 13:30:11 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13764 12444 0 3 1301 16

🟢 2024-08-14 13:30:54 UTC ydbd size 8.1 GiB changed* by +272 Bytes, which is < 100.0 KiB vs stable-24-3: OK

ydbd size dash stable-24-3: 74a9fd5 merge: 28c748a diff diff %
ydbd size 8 723 958 792 Bytes 8 723 959 064 Bytes +272 Bytes +0.000%
ydbd stripped size 476 914 056 Bytes 476 914 056 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit f31bfa8 into ydb-platform:stable-24-3 Aug 14, 2024
@niksaveliev niksaveliev mentioned this pull request Aug 15, 2024
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Aug 23, 2024
Closed
@swalrus1 swalrus1 mentioned this pull request Sep 3, 2024
Closed
This was referenced Oct 29, 2024
Closed
Closed
@serbel324 serbel324 mentioned this pull request Nov 19, 2024
Merged
@GrigoriyPA GrigoriyPA mentioned this pull request Feb 21, 2025
Closed
This was referenced Jun 3, 2025
Closed
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jul 28, 2025
Closed
@StekPerepolnen StekPerepolnen mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fomichev3000 fomichev3000 fomichev3000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcherednik @fomichev3000